• GeneralARTIQ
  • Redundant device manager parameter in the fake Core

In the devices.py file within the artiq.sim module, the Core object takes in a device manager parameter that is not used. The code for the same is reproduced below for reference (pulled from the master branch). I was wondering if this is an issue that needs to be fixed.

class Core:
    def __init__(self, dmgr):
        self.ref_period = 1
        self._level = 0

    def run(self, k_function, k_args, k_kwargs):
        self._level += 1
        r = k_function.artiq_embedded.function(*k_args, **k_kwargs)
        self._level -= 1
        if self._level == 0:
            print(time.manager.format_timeline())
            time.manager.timeline.clear()
        return r

    def seconds_to_mu(self, seconds):
        return numpy.int64(seconds//self.ref_period)

    def mu_to_seconds(self, mu):
        return mu*self.ref_period