Missing LEDs in master Device Database Template

connorgoham

Looking at artiq_ddb_template.py, it appears that the Kasli LEDs are only added to the device database template when the base is standalone, not master. Is there a reason for this? It is useful to have control of the LEDs for diagnostic purposes, e.g. have the idle kernel blinking them to verify at a glance it is running.

sb10q

On Kasli 1, the LEDs are used as DRTIO link status indicator.
On Kasli 2, there are additional USER LEDs, but nobody added the code so the LEDs are present on master and satellite builds as well. Maybe you could send a patch? That's not very difficult but needs testing.

jbqubit

Removing the following conditional block will enable LEDs on master and satellite, right?

jbqubit

https://github.com/m-labs/artiq/blob/4fb8ea5b7332a74b43e4f2c023aa39e88ad99dba/artiq/frontend/artiq_ddb_template.py#L553

sb10q

It won't, all it'll do is break Kasli 1 DRTIO.